77427 - advanced edit for table properties doesn't work <table>

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P2)

Description

[Kathleen :Brade]

The advanced edit dialog doesn't seem to work for table properties.

 * new composer page
 * insert table (2x2 is fine)
 * go back to properties
 * switch to table tab
 * click advanced edit button
 * add some properties (like id=mytable and foo=bar)
 * click OK to advanced edit button
 * click advanced edit button to see that the properties are still listed there
 * dismiss advanced edit dialog
 * click OK to table dialog
 * go to html source or back to advanced edit dialog for <table>
Notice that the attributes were never added.

Comment 1

[Charles Manske]

I'm in the middle of a major revision for this dialog, so I can't even test
this bug. It will be fixed "automatically" when bug 71743 is fixed.

Comment 2

[Charles Manske]

Adding keyword to track Advanced Edit dialog bugs that will be fixed with
bug 71743

Comment 3

[Charles Manske]

Moving dependent Advance Edit Dialog bugs to 0.9.2

Comment 4

[Kathleen :Brade]

remove dependency on bug #71743
the fix there really has nothing to do with this bug (and doesn't fix it).

I think this bug is particular bad because we can change an existing id in the 
dialog but it doesn't get recorded in the dom.

Comment 5

[Charles Manske]

I disagree. This works fine in my build!
I added both "id" and "foo", and they show up in
HTML source after inserting a table.
I doesn't matter if we leave off the dependency, we will have to verify it
separately anyway.

Comment 6

[Kathleen :Brade]

note: remember to get to the advanced edit dialog from the *table* tab (not the 
cell tab)

Comment 7

[Charles Manske]

Attachment: Fix.

Comment 8

[Charles Manske]

Patch fixes the problem after using Advanced Edit. Also fixes an error in the
table align code that prevented "right" align from working, as well as removing a
method that doesn't exist (SetSpanEnabled).

Comment 9

[Charles Manske]

sr=kin

Comment 10

[Charles Manske]

r=sfraser

Comment 11

[Asa Dotzler [:asa]]

a= [e-mail] for checkin to the trunk.
(on behalf of drivers)

Comment 12

[Charles Manske]

checked in.

Comment 13

[Charles Manske]

Attachment: Fix for problem in EdInsertTable.js (forgot to include before)

Comment 14

[sujay]

verified in 6/25 build.