776283 - function.toString() is missing trailing }

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Alice0775 White]

Build Identifier:
http://hg.mozilla.org/mozilla-central/rev/446b788ab99d
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/17.0 Firefox/17.0 ID:20120721041038

For ex. evaluate the following code in Scratchpad(need chrome right)
alert( getBrowserSelection.toString() )
Then there is missing trailing }

Step To Reproduced
1. Open Firefox with Clean profile
2. Set devtools.chrome.enabled = true in about:config
3. Open Scratchpad (Shift+F4) and Environment > Browser checked
4. Run alert( getBrowserSelection.toString() )

Actual Results
  missing trailing }
 
Expected Resuls
  Should not

Regression window:
Good:
http://hg.mozilla.org/integration/mozilla-inbound/rev/6e09c52e2c73
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/17.0 Firefox/17.0 ID:20120720111908
Bad:
http://hg.mozilla.org/integration/mozilla-inbound/rev/f9b341d6babd
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/17.0 Firefox/17.0 ID:20120720112708
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=6e09c52e2c73&tochange=f9b341d6babd


Regressed by Bug 761723

Comment 1

[:Benjamin Peterson]

The source needs to be decoded with nsScriptLoader::ConvertToUTF16 before being passed to the JS engine.

Comment 2

[:Benjamin Peterson]

Attachment: decode the source properly

Comment 3

[:Benjamin Peterson]

Attachment: decode source properly

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 644759 [details] [diff] [review]
decode source properly

r=me

Comment 5

[:Benjamin Peterson]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1485b7d63b61

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1485b7d63b61

Comment 7

[Lukas Blakk [:lsblakk] use ?needinfo]

no need to track for 17, it's fixed. adjusting flags accordingly.

Comment 8

[Morar Mihai]

I verified on Windows 7 X86, Ubuntu X32 and Mac 10.8 and it is not reproducing on Firefox 17.0b5.