777283 - add 'time' to the valid states of the input element's type attribute.

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[Raphael Catolino (:raphc)]

Attachment: patch

Comment 2

[Mounir Lamouri (:mounir)]

Comment on attachment 650606 [details] [diff] [review]
patch

Review of attachment 650606 [details] [diff] [review]:
-----------------------------------------------------------------

What about test_bug549475.html?
And adding _TIME in ShouldBeInElements() (nsHTMLFormElement.cpp)

Maybe you should make IsRangeUnderflow and IsRangeOverflow not working for time for the moment?

::: content/html/content/public/nsIFormControl.h
@@ +234,5 @@
>           aType == NS_FORM_INPUT_URL ||
>           // TODO: this is temporary until bug 635240 is fixed.
>           aType == NS_FORM_INPUT_NUMBER ||
>           aType == NS_FORM_INPUT_DATE ||
> +         aType == NS_FORM_INPUT_TIME ||

Bug 773205 for _DATE and _TIME, right? Can you add a TODO comment?

Comment 3

[Mounir Lamouri (:mounir)]

Comment on attachment 650606 [details] [diff] [review]
patch

Review of attachment 650606 [details] [diff] [review]:
-----------------------------------------------------------------

What about test_bug549475.html?
And adding _TIME in ShouldBeInElements() (nsHTMLFormElement.cpp)

Maybe you should make IsRangeUnderflow and IsRangeOverflow not working for time for the moment?

::: content/html/content/public/nsIFormControl.h
@@ +234,5 @@
>           aType == NS_FORM_INPUT_URL ||
>           // TODO: this is temporary until bug 635240 is fixed.
>           aType == NS_FORM_INPUT_NUMBER ||
>           aType == NS_FORM_INPUT_DATE ||
> +         aType == NS_FORM_INPUT_TIME ||

Bug 773205 for _DATE and _TIME, right? Can you add a TODO comment?

Comment 4

[Mounir Lamouri (:mounir)]

And also, could you update the b2g file that has the hack to detect 'time' input types?

Comment 5

[Raphael Catolino (:raphc)]

Attachment: patch

Comment 6

[Mounir Lamouri (:mounir)]

Comment on attachment 653769 [details] [diff] [review]
patch

Review of attachment 653769 [details] [diff] [review]:
-----------------------------------------------------------------

min/max, rangeunderflow and rangeoverflow should be updated too.
You also forgot to update test_bug549475.html.

Seems like this patch and the previous one are the same. Did you attach the correct one?

Comment 7

[Mounir Lamouri (:mounir)]

Attachment: Patch

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 698727 [details] [diff] [review]
Patch


>-         // TODO: this is temporary until bug 773205 is fixed.
>+         // TODO: those are temporary until bug 773205 is fixed.
these


And more tests and the rest of the implementation are coming in the other bugs, right?

Comment 9

[Mounir Lamouri (:mounir)]

(In reply to Olli Pettay [:smaug] from comment #8)
> And more tests and the rest of the implementation are coming in the other
> bugs, right?

Yes.

Actually, I will land this so it can be used by mobile platforms (Android and FxOS). Which means there will be no in-page UI but the system UI is going to be used.

Comment 10

[Olli Pettay [:smaug][[e-mail]]]

How does it work then on desktop builds?

Comment 11

[Mounir Lamouri (:mounir)]

(In reply to Olli Pettay [:smaug] from comment #10)
> How does it work then on desktop builds?

<input type='time'> will be ignored. It is behind a pref that is enabled by default on Android and FxOS. This is already the case with <input type='number'> and <input type='date'>.

Comment 12

[Mounir Lamouri (:mounir)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/874e845b13c2

Comment 13

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/874e845b13c2

Comment 14

[Florian Scholz (Open Web Docs)]

See bug 866430 for documentation.