788172 - Proxy is not a function (typeof Proxy should be 'function')

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[David Bruant]

Additionally to typeof, "Proxy" should be callable and do the same thing as "new Proxy"

Comment 1

[Jason Orendorff [:jorendorff]]

Attachment: v1

The spec is vague at present but this seems clearly what's intended.

With this patch, Proxy(...) behaves exactly like new Proxy(...).

I thought it should get at least a little test coverage, so in addition to the obvious tests I also did s/new Proxy/Proxy/g on jit-test/tests/proxytest*1.js, arbitrarily switching a few existing tests to the new syntax.

Comment 2

[Jason Orendorff [:jorendorff]]

Review ping! (I know, king of hypocrites here)

Comment 3

[Eddy Bruel [:ejpbruel]]

Comment on attachment 685134 [details] [diff] [review]
v1

Review of attachment 685134 [details] [diff] [review]:
-----------------------------------------------------------------

Patch looks good Jason! No comments.

I do have a question though: what exactly are cached protos?

Comment 4

[Tom S. (please needinfo tschuster)]

We should get this rebased and landed.

Comment 5

[Sankha Narayan Guria [:sankha]]

Attachment: rebased patch

I have rebased the old patch. Should be good to land now!

Comment 6

[Eddy Bruel [:ejpbruel]]

Comment on attachment 757415 [details] [diff] [review]
rebased patch

Review of attachment 757415 [details] [diff] [review]:
-----------------------------------------------------------------

Looks like this patch was rebased, but never landed, probably because it was flagged for review. In general, I don't think its necessary to review a patch again if its a simple rebase.

Comment 7

[Sankha Narayan Guria [:sankha]]

Attachment: rebased again

Rebased the patch once again.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/09dcdc2b2120

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/09dcdc2b2120

Comment 10

[Kohei Yoshino [:kohei]]

Added: https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/25/Site_Compatibility