790126 - Built-in controls for <video> doesn't have ability to go to fullscreen mode

Status: RESOLVED DUPLICATE of bug 704229

(Core :: Audio/Video, defect)

Description

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

+++ This bug was initially created as a clone of Bug #762730 +++

When the play button of a <video controls> element is clicked by the user we should go to fullscreen mode automatically on small-screen devices such as what's used for basecamp.

We might also want to do this for fennec, but I'll leave that up to whoever writes a patch here.

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

For what it's worth, I don't think this is a blocker.

Comment 2

[Chris Lee [:clee]]

What's the behavior today?  Controls and additional UI are present?

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

I believe so. Controls are present with has a button to go into fullscreen mode.

Note that this bug is about <video> elements in webpages (and in apps). It's not about what the video or gallery apps do.

Comment 4

[Chris Lee [:clee]]

I agree if full screen can be user initiated, this is not a blocker.

Comment 5

[[e-mail] [:onecyrenus]]

Full screen can be initiated in the video / gallery apps. 

Full screen cannot be initiated when browsing on the web and playing a video, unless the web site is using a web library like popcornjs. 

The user experience is that you can either turn controls on or off.  Neither has the ability to go fullscreen. 

You can go fullscreen by writing your own set of controls, and building a way to trigger a fullscreen request (mozfullscreen).

Comment 6

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Ouch. Definitely seems like a problem that the built-in controls doesn't have the ability to go fullscreen at all.

Comment 7

[Chris Lee [:clee]]

I thought we support this on Desktop today already?

Comment 8

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

We do. But I think we use a different set of built-in controls on mobile devices to accommodate for the small screen.

Comment 9

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

I assume this is the same in Fennec?

Comment 10

[Andrew Overholt [:overholt]]

Based on Fennec having the same behaviour, not blocking for basecamp.  Re-nom if that's incorrect :)

Comment 11

[[e-mail] [:onecyrenus]]

Andrew possibly we should consider that the use case is different here, in that on android playing videos is done by an app launching an activity.  And the video app will handle the playing off the video. 

The question in the Mozilla ecosystem is whether we would rather devs call an activity to play a video, or embed the video within their site. I imagine they will go for the easier of the two. 

Not sure we should model this after fennec. 

For me it was very difficult to view hd videos as there was no full screen and the video size was larger than screen size. "pinch and zoom" did not work in this scenario. 

Other thoughts on the matter would be good.

Comment 12

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

I don't think we'll ever need to force developers to display the video in a separate app. It's pretty easy for a website to make the video go fullscreen when the user starts to play it. Even when using built-in controls.

Comment 13

[Andrew Overholt [:overholt]]

(In reply to [e-mail]  [:onecyrenus] from comment #11)
> For me it was very difficult to view hd videos as there was no full screen
> and the video size was larger than screen size. "pinch and zoom" did not
> work in this scenario. 

This seems like a bug of its own.

Comment 15

[Hallvord R. M. Steen [:hallvors]]

This bug now means users can't choose to play YouTube videos embedded on other sites in full screen, see last dup.

Comment 16

[Kevin Brosnan [Ex-Mozilla]]

This is a really bad experience for users. https://support.mozilla.org/en-US/questions/984287

Comment 17

[Deb Richardson [:dria] (plz NEEDINFO)]

Ok, Ian and I chatted and we do want to do a button for this. Will switch needinfo over to Ian for designs.

Comment 18

[Wesley Johnston (:wesj)]

This is being done in bug 704229.