812055 - provide better naming for ETextEquivRule constants

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[alexander :surkov (:asurkov)]

Now ETextEquivRule have 
eNoRule
eFromSubtreeIfRec
eFromSubtree
eFromValue

Role map look like:
ROLE(SPINBUTTON,
     "spinbutton",
     ATK_ROLE_SPIN_BUTTON,
     NSAccessibilityIncrementorRole,  //Subroles: Increment/Decrement.
     ROLE_SYSTEM_SPINBUTTON,
     ROLE_SYSTEM_SPINBUTTON,
     eFromValue)

There's no any single bit pointing what eFromValue is. I suggest to rename those to have move verbal names like:

eNoNameRule
eNameFromSubtreeIfReqRule
eNameFromSubtreeRule
eNameFromValueRule

'Rule' in the end to avoid collisions with ENameValueFlag constants which contains eNameFromSubtree for example. Basically ETextEquivRule is about how to compute name, ENameValueFlag is about how name was computed. They are close but not the same.

Sounds ok?

Comment 1

[Trevor Saunders (:tbsaunde)]

> Sounds ok?

sure

Comment 2

[alexander :surkov (:asurkov)]

ok, turning into gfb then

Comment 3

[Hao Gao (:hao)]

So just rename the names in the files below?
/accessible/src/base/nsTextEquivUtils.h
/accessible/src/base/RoleMap.h

Comment 4

[alexander :surkov (:asurkov)]

right

Comment 5

[Hao Gao (:hao)]

Attachment: rename variables

Comment 6

[alexander :surkov (:asurkov)]

Comment on attachment 681857 [details] [diff] [review]
rename variables

Review of attachment 681857 [details] [diff] [review]:
-----------------------------------------------------------------

yep but you forgot to change them in nsTextEquivUitls.cpp, it'd be nice if you make sure the patch builds before requesting a review.

Comment 7

[Hao Gao (:hao)]

Attachment: rename variables

Comment 8

[alexander :surkov (:asurkov)]

Comment on attachment 681886 [details] [diff] [review]
rename variables

Review of attachment 681886 [details] [diff] [review]:
-----------------------------------------------------------------

thanks!

Comment 9

[alexander :surkov (:asurkov)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/8043c63226d0

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/8043c63226d0