813019 - get rid of AccMutationEvent::mNode

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[alexander :surkov (:asurkov)]

spun off bug 678454 comment #12:

Replace document->GetContainerAccessible(aEvent->mNode); on aEvent->mAccessible->Parent(). We can do that because CreateTextChangeEventFor is called before we mutate the tree.

Comment 1

[Catalin Iordache]

Hi. I'm new here and I would like to work at this bug.

Comment 2

[Catalin Iordache]

In which file I have to look for the  GetContainerAccessible ?

Comment 3

[alexander :surkov (:asurkov)]

(In reply to Catalin Iordache from comment #2)
> In which file I have to look for the  GetContainerAccessible ?

you could use mxr tool to search things (for example, http://mxr.mozilla.org/mozilla-central/search?string=document-%3EGetContainerAccessible%28aEvent-%3EmNode%29;)

thank you for taking it.

Comment 4

[Catalin Iordache]

Attachment: replaces

Replace document->GetContainerAccessible(aEvent->mNode) with : aEvent->mAccessible->Parent()

Comment 5

[alexander :surkov (:asurkov)]

Catalin, you need to ask someone for review when you upload the patch (here you will find a list of peers for each component - https://wiki.mozilla.org/Modules/All). In this case I'd recommend Trevor for review.

Comment 6

[Trevor Saunders (:tbsaunde)]

Comment on attachment 692596 [details]
replaces

> NotificationController::CreateTextChangeEventFor(AccMutationEvent* aEvent)
> {
>   DocAccessible* document = aEvent->GetDocAccessible();
>-  Accessible* container = document->GetContainerAccessible(aEvent->mNode);
>+  Accessible* container = aEvent->mAccessible->Parent();

you should remove the member from AccMutationEvent class as well.

Comment 7

[Catalin Iordache]

i can't find AccMutationEvent class. Any hints?

Comment 8

[Trevor Saunders (:tbsaunde)]

(In reply to Catalin Iordache from comment #7)
> i can't find AccMutationEvent class. Any hints?

accessible/src/base/AccEvent.h

Comment 9

[Catalin Iordache]

Attachment: bug-813019

mNode from AccEvent.h removed

Comment 10

[Trevor Saunders (:tbsaunde)]

you should use [checkin-needed] white board field not checkin? flag.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Actually, the checkin-needed keyword is what you really want :)

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3dcf9f0a42d8

Comment 13

[Catalin Iordache]

sorry for my mistakes, next time I'll know what to do.

Comment 14

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/3dcf9f0a42d8