813772 - Compatibility errors for eval() or Function() don't include source file or line

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Compatibility Tools, defect)

Description

[Kris Maglione [:kmag]]

+++ This bug was initially created as a clone of Bug #776718 +++

These errors don't contain any reference to the file or line to which they refer, which has been causing a lot of confusion among the developers who received these errors. This is especially so since the message primarily refers to Function.toString changing, but is triggered by the use of eval() or Function()

Comment 1

[Matt Basta [:basta]]

Fixed:

https://github.com/mozilla/amo-validator/commit/bc9d058abda787b93ab49baae1444f9e8fcf5192

Comment 2

[Kris Maglione [:kmag]]

That was fast. Thanks.

Notice:	`toString` for function objects has changed.
The `toString` implementation for function objects have changed. If you are using `eval` or `Function` to change the behavior of 'native' functions, it is probably not working correctly in Firefox 17 and above.
See https://bugzilla.mozilla.org/show_bug.cgi?id=761723 for details.
	Tier:	5
	File:	resources/greadmon/data/jquery-1.7.2.min.js
	Line:	2
	Column:	10897
	Context:
	> /*! jQuery v1.7.2 jquery.com | jquery.org/license */
	> ... );if(n.test(b.replace(o,"@").replace(p,"]").replace(q,"")))return(new Function("return "+b))();e.error("Invalid JSON: "+b)},parseXML:functio ...
	> a){var b=F.exec(a);b&&(b[1]=(b[1]||"").toLowerCase(),b[3]=b[3]&&new RegExp("(?:^|\\s)"+b[3]+"(?:\\s|$)"));return b},H=function(a,b){var c=a. ...