815030 - background at http://k0s.org/pictures/specialfx/ no longer rendered

Status: VERIFIED FIXED

(Core :: Graphics, defect)

Description

[Jeff Hammel]

This used to work in firefox and still works in chromium.  The background at http://k0s.org/pictures/specialfx/ as specified by

"""
      body {
           background-image: url('/pictures/specialfx/oilstainreflection2.jpg');
           background-repeat:no-repeat;
           background-position: right;
           background-attachment: fixed;
           background-size: 100% 100%;
      }
"""

is no longer rendered.  If I unset background-attachment: fixed; it does work, albeit I want background-attachment: fixed; for this page.  I'm not sure when this first stopped working.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Pretty unlikely to be DOM.

Jeff, can you find a regression range on nightlies?  Are you seeing this on Linux?  Because I see the background just fine on Mac, both with a current nightly and Firefox 17.

Comment 2

[Alice0775 White]

I can reproduce if HWA.
http://hg.mozilla.org/releases/mozilla-aurora/rev/4e0a8f234a6d
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:19.0) Gecko/19.0 Firefox/19.0 ID:20121124042012
and
http://hg.mozilla.org/mozilla-central/rev/3c67034ba39c
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:20.0) Gecko/20.0 Firefox/20.0 ID:20121125030729

Steps to reproduce:
1. Disable HWA
2. Clear cache (if it is not a first attempt)
3. Restart Browser
4. Open http://k0s.org/pictures/specialfx/

Actual results:
Backgound is not rendered.
Reload page helps.

Expected results:
Background should be rendered at the first loading.


Regression wndow(m-c)
Good:
http://hg.mozilla.org/mozilla-central/rev/58ebb638a7ea
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:19.0) Gecko/19.0 Firefox/19.0 ID:20121115172150
Bad:
http://hg.mozilla.org/mozilla-central/rev/a7ed19f7d21a
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:19.0) Gecko/19.0 Firefox/19.0 ID:20121116090659
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=58ebb638a7ea&tochange=a7ed19f7d21a


Regression wndow(m-i)
Good:
http://hg.mozilla.org/integration/mozilla-inbound/rev/244493403e89
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:19.0) Gecko/19.0 Firefox/19.0 ID:20121115151651
Bad:
http://hg.mozilla.org/integration/mozilla-inbound/rev/2c2c6ddb6fe6
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:19.0) Gecko/19.0 Firefox/19.0 ID:20121115163151
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=244493403e89&tochange=2c2c6ddb6fe6
Suspected: Bug 810470

Comment 3

[Alice0775 White]

err in comment #2
s/I can reproduce if HWA./I can reproduce if HWA off./

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: testcase

The background should turn green, but does not.

The problem is that the background image caching we do in nsDisplayCanvasBackground::Paint never invalidates the CachedBackgroundImage in response to the image loading, or being changed.

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

And nsIFrame::ClearDisplayItemCache is never called.

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/12c06dee84cb

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/12c06dee84cb

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/12c06dee84cb

Comment 10

[Jeff Hammel]

confirmed: wfm :) thanks!

Comment 11

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 685521 [details] [diff] [review]
fix

[Approval Request Comment]
Bug caused by (feature/regressing bug #): DLBI
User impact if declined: Missing background image on Web site
Testing completed (on m-c, etc.): a few days on m-c
Risk to taking this patch (and alternatives if risky): Low risk. Just invalidates some cached stuff more often.
String or UUID changes made by this patch: None

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/8eddfb7ae27d
https://hg.mozilla.org/releases/mozilla-beta/rev/bcd95b43b6c6

Comment 13

[Mihai Morar, (:MihaiMorar)]

WFM for Windows 7 x64, Ubuntu x86 and Mac OS 10.8 for FF18b4.

Comment 14

[Manuela Muntean [Away]]

Verified fixed on Firefox 18 beta 4. (especially because of the testcase attached in comment 4; while following the STR from comment 2, I couldn't see significant changes between a Nightly from 2012-11-16 and beta 4).

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:18.0) Gecko/20100101 Firefox/18.0
Build ID: 20121212073002

Comment 15

[Manuela Muntean [Away]]

Verified fixed on Firefox 19 beta 2, based on the testcase provided in comment 4, with HWA on and off.

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:19.0) Gecko/20100101 Firefox/19.0
Build ID: 20130116072953

Comment 16

[Mihai Morar, (:MihaiMorar)]

Fix is verified on FF20b5 too:

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:20.0) Gecko/20100101 Firefox/20.0(20130313170052)

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:20.0) Gecko/20100101 Firefox/20.0(20130313170052)