815043 - Assertion failure: "AncestorHasDirAuto set on node but not its children"

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Jesse Ruderman]

Attachment: testcase (asserts fatally when loaded)

Assertion failure: !aElement->AncestorHasDirAuto() || child->AncestorHasDirAuto() (AncestorHasDirAuto set on node but not its children), at content/base/src/DirectionalityUtils.cpp:665

Comment 1

[Jesse Ruderman]

Attachment: stack

Comment 2

[Simon Montagu :smontagu]

Attachment: Patch

The only semantic change here is adding 

+  if (!DoesNotParticipateInAutoDirection(aElement) &&
+      !aElement->NodeInfo()->Equals(nsGkAtoms::bdi) &&

to the conditions for setting AncestorHasDirAuto when binding a new element to a document. We need this condition because the descendants of these elements are never going to affect the directionality of their ancestors.

The rest of the patch is just moving code around.

Comment 3

[Peter Van der Beken [:peterv]]

Comment on attachment 689603 [details] [diff] [review]
Patch

Review of attachment 689603 [details] [diff] [review]:
-----------------------------------------------------------------

Please add the testcase as an automated test.

::: content/base/src/DirectionalityUtils.cpp
@@ +614,2 @@
>  void
> +WalkAncestorsResetAutoDirection(Element* aElement, bool aNotify = true)

Just pass in true in the one caller that omits aNotify.

@@ +886,5 @@
> +{
> +  // Set the AncestorHasDirAuto flag, unless this element shouldn't affect
> +  // ancestors that have dir=auto
> +  if (!DoesNotParticipateInAutoDirection(aElement) &&
> +      !aElement->NodeInfo()->Equals(nsGkAtoms::bdi) &&

Hmm, this should be |!aElement->IsHTML(nsGkAtoms::bdi)|. And file a bug to fix all the other spots where we made this mistake.

Comment 4

[Simon Montagu :smontagu]

https://hg.mozilla.org/integration/mozilla-inbound/rev/31a28a59de39
https://hg.mozilla.org/integration/mozilla-inbound/rev/7eb3d3124d24

Comment 5

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/31a28a59de39
https://hg.mozilla.org/mozilla-central/rev/7eb3d3124d24