864342 - IonCaches.cpp:579:53: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Daniel Holbert [:dholbert]]

New GCC build warning:
{
js/src/ion/IonCaches.cpp:579:53: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

   if (idint < 0 || idint >= argsObj.initialLength())
}
added here: http://hg.mozilla.org/mozilla-central/rev/503a5fb6d530#l1.64 for bug 861596.

idint is signed,  argsObj.initialLength() is unsigned. By the time we're comparing them, we know idint is nonnegative, so we can just static_cast it.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix

Comment 2

[Kannan Vijayan [:djvj]]

Comment on attachment 740311 [details] [diff] [review]
fix

Review of attachment 740311 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for taking care of this!

Comment 3

[Daniel Holbert [:dholbert]]

Thanks! Landed:
  https://hg.mozilla.org/integration/mozilla-inbound/rev/ba1a51d840b3

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ba1a51d840b3