872271 - [webvtt] verify media element src attributes return urls

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Ralph Giles (:rillian)]

In a review comment on bug 833385, bz asked if we had reflection testing for the <track> dom api, and why it hadn't caught that I was returning a string for track.src without normalizing it as an URL.

We should make sure we test this for <track> and the other media elements.

Comment 1

[Ralph Giles (:rillian)]

For example:

var t = document.createElement('track');
t.src = 'foo/bar/../baz.vtt';

incorrect behaviour:
t.src == 'foo/bar/../baz.vtt';

correct behaviour:
t.src == 'https://example.com/foo/baz.vtt';

Comment 2

[Marcus Saad (:msaad)]

Ralph, the source property wasn't included on the tests because by the time we were creating them, it was agreed that this would be "validated by the user" meaning whatever it means.

I'll include it on the upcoming tests using reflect.js for the HTMLTrackElement, and possibly on the other classes as well.

Comment 3

[Rick Eyre (:reyre)]

This will be landing in bug 833386 using reflect.js testing:

reflectURL({
  element: document.createElement("track"),
  attribute: "src",
  otherValues: ["foo", "bar", "\u0000", "null", ""]
});