901805 - reporting network activity in nsUDPServerSocket

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

The network activity notification only triggered by the traffic through nsSocketTransportService interfaces, however, nsUDPSocket uses NSPR directly. We'll need to invoke NetworkActivityMonitor::AttachIOLayer explicitly for the UDP socket.

Comment 1

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Attachment: Part 2 - use NetworkActivityMonitor as a proxy for accessing udp socket

Comment 2

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Attachment: Part 1 - only invoke PR_Sendto on STS thread

Make sure PR_Sendto is invoked on STS thread because NetworkActivityMonitor will check the current thread.

Comment 3

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

The patch part 2 is not depending on the modification for UDP socket e10s. I'm thinking we can directly check patch part 2 solely in this bug and merge the patch part 1 into the modification for UDP socket e10s in bug 869869.
Honza and Patrick, how do you think?

Comment 4

[Honza Bambas (:mayhemer)]

If that is simpler for you, then go ahead.  It's clear bug 869869 should land soon (blocks other 3 bugs, at least).  If postponing this bug will make landing that bug sooner, then it's a good thing to do.

Comment 5

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Attachment: use NetworkActivityMonitor as a proxy for accessing udp socket

https://tbpl.mozilla.org/?tree=Try&rev=0c7362ffeb09

Comment 6

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

I decide to make this bug independent from bug 869869.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/76488552d101

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/76488552d101