917454 - [typed objs] Add objectType function

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Niko Matsakis [:nmatsakis]]

Per http://wiki.ecmascript.org/doku.php?id=harmony:typed_objects#introspection

Comment 1

[Niko Matsakis [:nmatsakis]]

Attachment: Bug917454.diff

Comment 2

[Till Schneidereit [:till]]

Comment on attachment 824949 [details] [diff] [review]
Bug917454.diff

Review of attachment 824949 [details] [diff] [review]:
-----------------------------------------------------------------

Nice! r=me with nits addressed. And then there's the obligatory reminder to add a license header to the test file. :)

::: js/src/builtin/TypedObject.cpp
@@ +41,5 @@
>      JS_ConvertStub
>  };
>  
> +static const JSFunctionSpec TypedObjectMethods[] = {
> +    {"objectType", {nullptr, nullptr}, 1, 0, "TypeOfTypedDatum"},

Please use the JS_SELF_HOSTED_FN macro here.

@@ +1336,5 @@
> +GlobalObject::initTypedObject(JSContext *cx, Handle<GlobalObject*> global)
> +{
> +    RootedObject TypedObject(cx);
> +    TypedObject = NewObjectWithGivenProto(cx, &TypedObjectClass, global->getOrCreateObjectPrototype(cx),
> +                                   global, SingletonObject);

Nit: indentation is off

Comment 3

[Niko Matsakis [:nmatsakis]]

Try run: https://tbpl.mozilla.org/?tree=Try&rev=1bf9e812b23e

appears to be clean, though numerous infrastructure failures make it a bit hard to be sure.

Comment 4

[Niko Matsakis [:nmatsakis]]

Attachment: Bug917454.diff

Carrying over r+ from till

Comment 5

[Niko Matsakis [:nmatsakis]]

https://tbpl.mozilla.org/?tree=Try&rev=1bf9e812b23e

Comment 6

[Niko Matsakis [:nmatsakis]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/dcda572f9956

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/dcda572f9956