Closed
Bug 918289
Opened 12 years ago
Closed 12 years ago
[webvtt] Remove videos from TextTrack* tests where not needed
Categories
(Core :: Audio/Video, defect)
Core
Audio/Video
Tracking
()
RESOLVED
FIXED
mozilla29
People
(Reporter: reyre, Assigned: reyre)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
In bug 893309 Chris commented that we shouldn't be using loading video's with the track element if we don't need them. ASFAIK we don't need them to load text tracks and all the text track tests currently use them.
We should remove the videos. If we do need the videos we should "include manifest.js in the <head>, and call getPlayableVideo(gSmallTests), so that this test works if webm is disabled."
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → rick.eyre
|
|
Assignee | |
Comment 1•12 years ago
|
||
I had a look through all the text track tests that use a video source and there are a few. Most of them need it though, in order to have the VTT file loaded.
I only found one tests where the video wasn't needed.
Attachment #8366046 -
Flags: review?(cpearce)
|
||
Updated•12 years ago
|
Attachment #8366046 -
Flags: review?(cpearce) → review+
|
|
Assignee | |
Comment 2•12 years ago
|
||
Thanks for review Chris.
Try push: https://tbpl.mozilla.org/?tree=Try&rev=c3e23eda041b
|
||
Comment 4•12 years ago
|
||
Flags: in-testsuite+
Keywords: checkin-needed
|
||
Comment 5•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
|
||
Updated•12 years ago
|
Summary: [webvtt] Remove video's from TextTrack* tests where not needed → [webvtt] Remove videos from TextTrack* tests where not needed
You need to log in
before you can comment on or make changes to this bug.
Description
•