931093 - [Camera] Update app to specify suitable thumbnailSize

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[Mike Habicher [:mikeh] (high bugzilla latency)]

Adding capabilities.thumbnailSizes and .thumbnailSize to CameraControl API in bug 807058; will also remove the pictureSize option from takePicture() and change it to a .pictureSize attribute.

camera.js will need to change to use these.

This bug should complete the dependency chain.

Comment 1

[Diego Marcos [:dmarcos]]

Attachment: It sets the thumbnail size using the new camera API

Comment 2

[Wayne Chang [:wchang]]

Required for HD

Comment 3

[Mike Habicher [:mikeh] (high bugzilla latency)]

Diego, if you like, you can now remove [1] and just set camera.pictureSize in [2].

1. https://github.com/mozilla-b2g/gaia/blob/master/apps/camera/js/camera.js#L1346
2. https://github.com/mozilla-b2g/gaia/blob/master/apps/camera/js/camera.js#L904

The camera now keeps and can inform you of its configured picture size.

Comment 4

[Diego Marcos [:dmarcos]]

Attachment: Pull Request

Comment 5

[David Flanagan [:djf]]

Comment on attachment 825680 [details] [review]
Pull Request

See my comments on github.  But r- because you're finding the last big-enough thumbnail size rather than the smallest big-enough thumbnail.

Comment 6

[Diego Marcos [:dmarcos]]

I was doing a final test of patch prior to merge it and I observed a strange behavior of the CameraControl API. My code picks one of the thumbnail sizes obtained from CameraControl.capabilities.thumbnailSizes. I set the thumbnail size using CameraControl.thumbnailSize. I check the value after setting it and it returns a different size. e.g:

I set: 

camera.thumbnailSize = {height:320, width:480}

I check the value and I get:

camera.thumbnailSize -> {height:384, width:512}

If I set:

camera.thumbnailSize = {height:720, width:1280} // The largest available size for the thumbnail

When I check the value I get:

camera.thumbnailSize -> {height:480, width:640} 

Is CameraControl selecting the proper thumbnail size? Is this a bug or something I'm not understanding?

Comment 7

[Mike Habicher [:mikeh] (high bugzilla latency)]

During testing, I observed that the camera driver was failing to take a photo if the aspect ratio of the thumbnail size does not match the aspect ratio of the picture size, so the API makes sure this matches. The selected thumbnail size will be closest in area to the size you specified, and the getter will reflect this.

Internally, the API keeps track of the thumbnail size you tried to set, so that if you then choose a picture size with an aspect ratio that matches your specified thumbnail size, the thumbnail size will be adjusted to reflect that as well. This means you can do:

  .thumbnailSize = { ... };
  .pictureSize = { ... };

...and things will work as expected.

Comment 8

[Diego Marcos [:dmarcos]]

I modified the patch to take into account the aspect ratio of the screen when selecting a thumbnail size

Comment 9

[David Flanagan [:djf]]

Comment on attachment 825680 [details] [review]
Pull Request

The thumbnail aspect ratio should match the picture aspect ratio, not the screen aspect ratio.

Comment 10

[David Flanagan [:djf]]

Comment on attachment 825680 [details] [review]
Pull Request

Diego,

There are a few more things to fix, but feel free to land this once you've addressed my comments on github.  Or set r? again if you'd like me to take another look.

Comment 11

[Diego Marcos [:dmarcos]]

Merged on master:

https://github.com/dmarcos/gaia/commit/72b690c30450b8c86a3ee2a385f44dd88c51941a

Comment 12

[Diego Marcos [:dmarcos]]

Attachment: Pull request for v.1.1.0hd

Comment 13

[Diego Marcos [:dmarcos]]

Attachment: Pull request for v1.2

Comment 14

[Diego Marcos [:dmarcos]]

Merged on v.1.1.0hd

https://github.com/dmarcos/gaia/commit/00c8cc45952cc963cc42dd00adbb542223367958

Merged on v1.2:

https://github.com/dmarcos/gaia/commit/09efce67dd81b198db18ff15c241f51269f2ab4d