933576 - [Dailer] In call page will be gone once press home > dialer > home > dialer during a call.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Enpei]

+++ This bug was initially created as a clone of Bug #917222 +++

Unable to hang up the call after pressing home key and back to dialer twice and press dial key on dialer again during the call. Please check reproduce steps and attached video which will make it more clear. Need to reboot to recover the issue.

(Ikura v1.1 has no such issue.
Gaia:     39b0203fa9809052c8c4d4332fef03bbaf0426fc
Gecko:    http://hg.mozilla.org/releases/mozilla-b2g18/rev/31fa87bfba88
BuildID   20131031041204
Version   18.0)

Reproduce bug on Buri
* Build Number             
Gaia:     df049e3177ced0ca493ff0d192c65f18392bb462
Gecko:    http://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/93eafd042c1c
BuildID   20131031004003
Version   26.0
   
Gaia:     412fd463bcb81f0e8bebf6d32500d0c02712748d                 
Gecko:    http://hg.mozilla.org/mozilla-central/rev/f0d363d72753        
BuildID   20131031040201   
Version   28.0a1 

* Reproduce Steps
1. Dial out a number(no need to be emergency call as filmed in the video)and connected.
2. After connected, press home key > dialer > home key > dialer, you will see dialer page become not-in-call status with dial green key on the bottom.

* Expected Result
No matter how many times pressing buttons between home and dialer keys, in-call page will always show when press dialer key.


* Actual Result
It goes to dialer page which is has no call status and end call button, only numeric keys and dial button.

* Occurrence rate
100%

Comment 1

[Enpei]

Attachment: 2013-11-01-10-49-16.png

Comment 2

[J Zimbrick]

Regression window on 1.2:

Last Working Build:
Device: Buri v1.2 Mozilla RIL
BuildID: 20130904040205
Gaia: b6c5bf1d24230bfed4a8f680e625fa2175001f82
Gecko: 7ff96bd19c1c
Version: 26.0a1
Base Image: 20131015

First Broken Build:
Device: Buri v1.2 Mozilla RIL
BuildID: 20130905040201
Gaia: ec885264d885d877d68980c0227058231f18ad09
Gecko: 77ed46bf4c1a
Version: 26.0a1
Base Image: 20131015

Comment 3

[Preeti Raghunath(:Preeti)]

David,

Please review as this seems to be a blocker.

Comment 4

[Tony Chung [:tchung]]

in-moztrap? to add a testcases to the dialer test suite

Comment 5

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Attachment: patch

Just found the cause...we really didn't remember dataset saves only strings :O

Alive may you help review this simple patch?

Comment 6

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 831374 [details]
patch

r+=me

Comment 7

[(inactive after 6/18) Alive Kuo [:alive]]

To me the plan is refine any dataset usage in AttentionWindow property but in this stage just stay tuned until it is implemented.

Comment 8

[KM Lee [:rexboy] (inactivate after Sep. 22)]

ok, thank you Alive! Since this is a blocker, let's just land it first.

master:
https://github.com/rexboy7/gaia/commit/4e5f2a3cf63d41b2de16c9e798cc9b8c3bc8bd96

Comment 9

[KM Lee [:rexboy] (inactivate after Sep. 22)]

sorry, should be
https://github.com/mozilla-b2g/gaia/commit/57a02515fb483ac9cdbcfb7d3ae939667c88db63

Comment 10

[Anthony Ricaud (:rik)]

Oh duh, I was so stupid when I implemented this. Thanks!

Comment 11

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 57a02515fb483ac9cdbcfb7d3ae939667c88db63 to:
v1.2: ae8930720e5f9b0a89c7980a9fa86f1d0c13c992

Comment 12

[Enpei]

Verified on Buri
Gaia:     ce276842c9ac1746073271fb736dfdb626a89240
Gecko:    http://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/36c4c667b9f2
BuildID   20131121004002
Version   26.0