939909 - Internal Promise implementation should not use Optional<JS::Handle<JS::Value> > forms

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

JS::Value already encodes the semantics of optional, this is redundant, especially in internal methods that are not wired to WebIDL. bz eventually plans to get rid of the |optional any| webidl form too.

Comment 1

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Attachment: Get rid of Optional<> from internal functions.

All cleaned up.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8334187 [details] [diff] [review]
Get rid of Optional<> from internal functions.

>@@ -315,19 +315,19 @@ Promise::JSCallback(JSContext *aCx, unsi
>+  JS::Rooted<JS::Value> value(aCx);
>   if (aArgc) {
>-    value.Value() = args[0];
>+    value = args[0];

  JS::Rooted<JS::Value> value(aCx, args.get(0));

Or even more simply, just pass args.get(0) in the places where "value" is passed right now and remove all this code.

Apart from that, looks great.  Thank you for doing this!

r=me

Comment 3

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/66ab5cb18c25

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/66ab5cb18c25