944632 - Add video capture permission to SYSTEM app to enable BOOKMARKED web pages acquires gUM

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[[e-mail]]

== follow-up of bug 944584 ==

Bug 916524 adds the the 'video-capture' permission to the browser so that web pages can access the video part of getUserMedia. Bookmarked web pages pinned to the homescreen however open in a mozbrowser window that is a child of the system app, not the browser. The system app doesn't have the 'video-capture' permission, so this API always failed in a bookmarked page pinned to the homescreen.

Simple, low risk fix: just need to add:

"video-capture": {},

to the system app manifest.

Comment 1

[Bruno Vilar]

I will take this one, ok? :) 

First patch..

Comment 2

[Bruno Vilar]

Patch https://github.com/mozilla-b2g/gaia/pull/14229#commits-pushed-f01bc11

Comment 3

[Joshua Smith [:joshua-s]]

Assigning Bruno!

Comment 4

[[e-mail]]

Hi bruno, nice try!

1. Good, you've assigned bug to yourself. 
2. For patch review, please click 'Add an attachment' link above comments section, 
3. paste your patch link there, and set review to module owner ([e-mail])

Please reference the slide of developing firefoxOS. 
http://www.slideshare.net/gasolin/develop-firefox-os1-28348187

If there's anything unclear, please needinfo? me ([e-mail]) :)

Comment 5

[Bruno Vilar]

Attachment: patchForBug944632.html

Couldn't find "video-capture" permission in permission table (https://mxr.mozilla.org/mozilla-central/source/dom/apps/src/PermissionsTable.jsm#36), but I think (and hope) it is correct. :)

Comment 6

[[e-mail]]

Comment on attachment 8340605 [details] [diff] [review]
patchForBug944632.html

Current master branch has merged the 'audio-capture' permission
https://github.com/mozilla-b2g/gaia/blob/master/apps/system/manifest.webapp

Please rebase to current master, put 'video-capture' permission under 'audio-capture' permission, and set review flag again.

Comment 7

[[e-mail]]

BTW, the reason why "video-capture" permission not in permission table is 
this feature is in development and target to land next week.
Though adding permission won't broken anything so we can do it promptly.

Comment 8

[Bruno Vilar]

Attachment: patchForBug944632.html

@gasolin, I didn't "rebase", but updated my repo with upstream and commited a new change putting 'video-capture' below 'audio-capture'.

If something is wrong, please, explain me. Maybe I couldn't understand something.

Comment 9

[[e-mail]]

Comment on attachment 8340624 [details] [diff] [review]
patchForBug944632.html

Looks good to me, thanks for fix it!

Comment 10

[[e-mail]]

merged to gaia-master https://github.com/mozilla-b2g/gaia/commit/f23aebebcd28c4d19347def77c4836c8baebc2ce


Congrats Bruno, You are ready to go!
Try to pick another bug?

Friendly reminder: for next time, please pick reviewer from module owners https://wiki.mozilla.org/Modules/FirefoxOS

Comment 11

[Bruno Vilar]

Fred,

Thank you. Your slides were very useful. =)