952190 - Pretty output for native objects from chrome windows

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P3)

Description

[Mihai Sucan [:msucan]]

We should have pretty output for native objects from chrome windows, like we have for objects from content tabs.

(follow up from bug 843004 comment 49)

Comment 2

[Mihai Sucan [:msucan]]

Gijs, to fix this bug, update DevToolsUtils.js:

this.isSafeJSObject = function isSafeJSObject(aObj) {
  if (Cu.getGlobalForObject(aObj) ==
      Cu.getGlobalForObject(isSafeJSObject)) {
    return true; // aObj is not a cross-compartment wrapper.
  }

  if (Cu.getObjectPrincipal(aObj) ==
      Cu.getObjectPrincipal(isSafeJSObject) {
    return true; // allow chrome objects
  }

  return Cu.isXrayWrapper(aObj);
};

... then write a test. Please use Task.spawn for the test.

Comment 3

[:Gijs (he/him)]

And on came a deluge of other stuff that was almost-but-not-quite-literally on fire. Needinfo'ing so I don't forget.

Comment 4

[Mihai Sucan [:msucan]]

Attachment: bug952190-1.diff

This is a quick fix that's useful for addon authors and for Firefox devs.

My previous comment was not entirely accurate. It seems the getObjectPrincipal() method was moved to the script security manager.

Comment 5

[Mihai Sucan [:msucan]]

Try push: https://tbpl.mozilla.org/?tree=Try&rev=b94df5d9ad19

Comment 6

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 8377727 [details] [diff] [review]
bug952190-1.diff

Review of attachment 8377727 [details] [diff] [review]:
-----------------------------------------------------------------

I see some breakage in tbpl, so clearing review for now.

Comment 7

[Mihai Sucan [:msucan]]

Attachment: bug952190-2.diff

Fixed the variables view test.

Green try push: https://tbpl.mozilla.org/?tree=Try&rev=cc4f30d3506b

Comment 8

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 8378395 [details] [diff] [review]
bug952190-2.diff

Review of attachment 8378395 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.

Comment 9

[Mihai Sucan [:msucan]]

Thanks!

Landed: https://hg.mozilla.org/integration/fx-team/rev/47fddf9651fd

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/47fddf9651fd