Closed
Bug 987178
Opened 11 years ago
Closed 11 years ago
Drop DOM_OBJECT classinfo from jsProtoHelper
Categories
(Chat Core :: General, defect)
Chat Core
General
Tracking
(Not tracked)
RESOLVED
FIXED
1.6
People
(Reporter: aleth, Assigned: aleth)
References
Details
Attachments
(1 file)
|
1.67 KB,
patch
|
florian
:
review+
|
Details | Diff | Splinter Review |
As per bug 981845, DOM_OBJECT classinfo in JS is going away. It appears we don't really want that flag anyway as unprivileged code should not be able to receive instances of the objects in jsProtoHelper.
|
Assignee | |
Comment 1•11 years ago
|
||
There don't seem to be any other instances of DOM_OBJECT for Instantbird.
Attachment #8395707 -
Flags: review?(florian)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8395707 [details] [diff] [review]
Drop DOM_OBJECT classinfo from jsProtoHelper
Note: we don't pass the DOM_OBJECT flag at http://lxr.instantbird.org/instantbird/source/purple/purplexpcom/src/purpleMessage.cpp#23 :
23 NS_IMPL_CLASSINFO(purpleMessage, NULL, 0, PURPLE_MESSAGE_CID)
(it would be instead of the "0" third parameter)
Attachment #8395707 -
Flags: review?(florian) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.6
You need to log in
before you can comment on or make changes to this bug.
Description
•