Closed Bug 994292 Opened 12 years ago Closed 11 years ago

Intermittent e10s test_video_wakelock.html | Video element locked the cpu - paused - got true, expected false | Video element locked the screen - paused - got true, expected false

Categories

(Core :: Audio/Video, defect)

Product:
Core
Component:
Audio/Video
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla35
Tracking Flags:
Tracking Status
e10s + ---
firefox33 --- fixed
firefox34 --- fixed
firefox35 --- fixed
firefox-esr31 --- unaffected
b2g-v2.0 --- fixed
b2g-v2.0M --- fixed
b2g-v2.1 --- fixed
b2g-v2.2 --- fixed

People

(Reporter: RyanVM, Assigned: jwwang)

Details

(Keywords: intermittent-failure)

Attachments

(2 files)

994292_fix_test_video_wakelock_html.patch
3.53 KB, patch
baku
: review+
Details | Diff | Splinter Review
994292_part2_fix_race_between_playing_and_wakelock_event.patch
4.39 KB, patch
baku
: review+
Details | Diff | Splinter Review
https://tbpl.mozilla.org/php/getParsedLog.php?id=37513446&tree=B2g-Inbound Ubuntu VM 12.04 x64 b2g-inbound opt test mochitest-e10s-1 on 2014-04-09 07:39:16 PDT for push 6e2596103f42 slave: tst-linux64-spot-045 07:49:32 INFO - 3683 INFO TEST-START | /tests/content/html/content/test/test_video_wakelock.html 07:49:33 INFO - 3684 INFO TEST-INFO | dumping last 5 message(s) 07:49:33 INFO - 3685 INFO TEST-INFO | if you need more context, please use SimpleTest.requestCompleteLog() in your test 07:49:33 INFO - 3686 INFO TEST-PASS | /tests/content/html/content/test/test_video_wakelock.html | Video element locked the cpu - paused 07:49:33 INFO - 3687 INFO TEST-PASS | /tests/content/html/content/test/test_video_wakelock.html | Video element locked the screen - paused 07:49:33 INFO - 3688 INFO TEST-PASS | /tests/content/html/content/test/test_video_wakelock.html | Video element locked the screen - paused 07:49:33 INFO - 3689 INFO TEST-PASS | /tests/content/html/content/test/test_video_wakelock.html | Video element locked the cpu - paused 07:49:33 INFO - 3690 INFO TEST-PASS | /tests/content/html/content/test/test_video_wakelock.html | There was at least milliseconds between the stop and the wakelock release 07:49:33 INFO - 3691 INFO TEST-UNEXPECTED-FAIL | /tests/content/html/content/test/test_video_wakelock.html | Video element locked the cpu - paused - got true, expected false 07:49:33 INFO - 3692 INFO TEST-UNEXPECTED-FAIL | /tests/content/html/content/test/test_video_wakelock.html | Video element locked the screen - paused - got true, expected false 07:49:34 INFO - 3693 INFO TEST-INFO | MEMORY STAT vsize after test: 833925120 07:49:34 INFO - 3694 INFO TEST-INFO | MEMORY STAT residentFast after test: 148926464 07:49:34 INFO - 3695 INFO TEST-INFO | MEMORY STAT heapAllocated after test: 36675888 07:49:34 INFO - 3696 INFO TEST-END | /tests/content/html/content/test/test_video_wakelock.html | finished in 1572ms
This is probably the top orange we hit on mochitest-e10s. Is there someone who can look into this?
Hi Star, Can you take a look?
Flags: needinfo?(scheng)
Same basic issue as bug 995438?
Flags: needinfo?(jwwang)
Seems so. I am cooking the patch and get ready for test.
Assignee: nobody → jwwang
Flags: needinfo?(scheng)
Flags: needinfo?(jwwang)
Call SpecialPowers.pushPermissions() to ensure permission change is completed before continuing the rest of the tests. Try: https://tbpl.mozilla.org/?tree=Try&rev=1df4a72aff45
Attachment #8498648 - Flags: review?(amarchesini)
Attachment #8498648 - Flags: review?(amarchesini) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/b2420771f64b
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Re-opening; it looks like this happened again (see comment 225).
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
It is possible for wakelock events to come before the 'playing' event to break the test. We should pause() only after receiving one cpu-lock and one screen-lock events. Try: https://tbpl.mozilla.org/?tree=Try&rev=a38591f693ab So far so good with over 100 runs.
Attachment #8500207 - Flags: review?(amarchesini)
Worth making equivalent changes to test_audio_wakelock.html while you're at it?
(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #232) > Worth making equivalent changes to test_audio_wakelock.html while you're at > it? Sure.
Attachment #8500207 - Flags: review?(amarchesini) → review+
Please check in 994292_part2_fix_race_between_playing_and_wakelock_event.patch. Thanks.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/8d3d8d907e4e
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: