998271 - Loop client notifier should accept l10n string ids

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect)

Description

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

Reference comment: https://github.com/mozilla/loop-client/pull/21#discussion_r11740524

NotificationListView should implement a notifyL10n method so we could pass it string ids directly, hence helping a lot testing for notification messages.

Comment 1

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

Attachment: https://github.com/mozilla/loop-client/pull/23

This patch adds support for notifier notifyL10n(), warnL10n() and errorL10n() (loop-client).

Comment 2

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

Attachment: https://github.com/adamroach/gecko-dev/pull/17

This patch uses newly introduced notifier notifyL10n(), warnL10n() and errorL10n() methods (desktop).

Comment 3

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 8408967 [details] [review]
https://github.com/mozilla/loop-client/pull/23

Looks good; r=dmose

Comment 4

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 8408968 [details] [review]
https://github.com/adamroach/gecko-dev/pull/17

Looks good; r=dmose

Comment 5

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

Landed loop-client PR 23: https://github.com/mozilla/loop-client/commit/f835e41e929aa6e6df6b1b5859e260378eee6e97

Comment 6

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

Landed gecko-dev PR 17: https://github.com/adamroach/gecko-dev/commit/180608a1da94d32802c06f630a2ec4625d700af2

Comment 7

[Mark Banner (:standard8)]

https://hg.mozilla.org/projects/elm/rev/bb74246f2ef8
https://hg.mozilla.org/projects/elm/rev/5bb2b9791657

Comment 8

[Mark Banner (:standard8)]

https://hg.mozilla.org/mozilla-central/rev/bb74246f2ef8
https://hg.mozilla.org/mozilla-central/rev/5bb2b9791657

Comment 9

[u279076]

Does this need QA testing? If so, please advise.

Comment 10

[Mark Banner (:standard8)]

(In reply to Anthony Hughes, QA Mentor (:ashughes) from comment #9)
> Does this need QA testing? If so, please advise.

You could test error messages, but we know they are working, and some will be changing soon, so I don't think it is worth it.

Comment 11

[u279076]

Deprioritizing QA testing as per comment 10. Please needinfo me to request QA.