1021732 - [Flame] Re-enable test_privileged_app_contacts_prompt

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[[:AndreiH]]

The test started to fail in:

http://selenium.qa.mtv2.mozilla.com:8080/view/B2G%20Flame/job/b2g.flame.mozilla-central.ui.non-smoketest/54/HTML_Report/

Needs to be investigated.

Traceback (most recent call last):
  File "/var/jenkins/workspace/b2g.flame.mozilla-central.ui.non-smoketest/.env/local/lib/python2.7/site-packages/marionette_client-0.7.7-py2.7.egg/marionette/marionette_test.py", line 163, in run
    testMethod()
  File "/var/jenkins/workspace/b2g.flame.mozilla-central.ui.non-smoketest/tests/python/gaia-ui-tests/gaiatest/tests/functional/system/test_privileged_app_contacts_prompt.py", line 28, in test_contact_prompt
    permission.wait_for_permission_dialog_displayed()
  File "/var/jenkins/workspace/b2g.flame.mozilla-central.ui.non-smoketest/tests/python/gaia-ui-tests/gaiatest/apps/homescreen/regions/permission_dialog.py", line 17, in wait_for_permission_dialog_displayed
    self.wait_for_element_displayed(*self._permission_dialog_locator)
  File "/var/jenkins/workspace/b2g.flame.mozilla-central.ui.non-smoketest/tests/python/gaia-ui-tests/gaiatest/apps/base.py", line 42, in wait_for_element_displayed
    lambda m: m.find_element(by, locator).is_displayed())
  File "/var/jenkins/workspace/b2g.flame.mozilla-central.ui.non-smoketest/.env/local/lib/python2.7/site-packages/marionette_client-0.7.7-py2.7.egg/marionette/wait.py", line 143, in until
    cause=last_exc)
TimeoutException: TimeoutException: Timed out after 20.1 seconds

Comment 1

[[:AndreiH]]

It seems that the "permission dialog" is not shown anymore after tapping on "Insert fake contacts".

STR:

1. Open UI tests app
2. Tap on Contacts
3. Tap on Insert fake contacts

Before there was a warning message that appeared: UI tests - Privileged App would like to access your contact list.

Is this intended?

Comment 2

[Zac C (:zac)]

It definitely sounds like a regression Andrei!

Comment 3

[Jason Smith [:jsmith]]

No - this is a regression, and a bad one at that.

Is this working on 1.4?

Comment 4

[[:AndreiH]]

This is not reproducible on v1.4 latest build:

Gaia      183efb374be1bcbf92f1fb3d0212a68b564a6d3e                         
Gecko  https://hg.mozilla.org/releases/mozilla-b2g30_v1_4/rev/960c48b5a5fa                                                                         
BuildID   20140606000204                                                   
Version   30.0                                                             
ro.build.version.incremental=94                                            
ro.build.date=Tue May 20 09:29:20 CST 2014

Comment 5

[Antonio Manuel Amaya Calvo (:amac)]

This is actually intended if the app is a preinstalled one. See bug 1014410

Comment 6

[Jason Smith [:jsmith]]

Discussed in IRC - bug 1014410 changes the behavior here, so we need to update the UI automation for privileged app tests to make sure that the relevant privileged APIs are set to prompt before running the test.

Comment 7

[[:AndreiH]]

Removing the tag, this remains for tracking test changes

Comment 8

[Zac C (:zac)]

I've updated the test but found a bug: bug 1024513.

I'll xfail and update the test at the same time.

Comment 9

[Zac C (:zac)]

Attachment: github pr

Comment 10

[Robert Chira [:RobertC]]

https://github.com/mozilla-b2g/gaia/commit/0bbeecfc239f0c3ab027be631b187f2dd9ca80be

Comment 11

[Viorela Ioia [:viorela]]

Attachment: Uplift to v2.0: https://github.com/mozilla-b2g/gaia/pull/20567

Comment 12

[Florin Strugariu [:Bebe]]

https://github.com/mozilla-b2g/gaia/commit/5da2b8a8c844af85b6825caa102f8cbe8b30b648

Comment 13

[Viorela Ioia [:viorela]]

Attachment: Github PR: https://github.com/mozilla-b2g/gaia/pull/21536

Bug 1024513 is fixed, so we can re-enable the test

Comment 14

[Florin Strugariu [:Bebe]]

https://github.com/mozilla-b2g/gaia/commit/942c3154cb7a475f725c98f6b69bbe5e383be321

Comment 15

[Viorela Ioia [:viorela]]

We need to re-enable the test on v2.0 too

Comment 16

[Viorela Ioia [:viorela]]

Attachment: PR for v2.0: https://github.com/mozilla-b2g/gaia/pull/21587

Comment 17

[[:AndreiH]]

Viorela can you please investigate also why it's failing on Travis:
https://travis-ci.org/mozilla-b2g/gaia/jobs/29585963

It is constantly failing.

Comment 18

[Zac C (:zac)]

(In reply to [:AndreiH] from comment #17)
> Viorela can you please investigate also why it's failing on Travis:
> https://travis-ci.org/mozilla-b2g/gaia/jobs/29585963
> 
> It is constantly failing.

Reverted it:
https://github.com/mozilla-b2g/gaia/commit/e347a0f1ffa02d5a4feb21dfbe3ffb69b6768c87

Let's investigate why it's failing on master first.

Comment 20

[Florin Strugariu [:Bebe]]

Viorela can you take a new look over this issue as it was reverted.

Comment 21

[Viorela Ioia [:viorela]]

Bebe, there's bug Bug 1037030 opened for this issue.

Comment 22

[Viorela Ioia [:viorela]]

Attachment: Github PR: https://github.com/mozilla-b2g/gaia/pull/21993

Bug 1037030 is fixed, I run the test on both device and desktopb2g and it passes

Comment 23

[Florin Strugariu [:Bebe]]

https://github.com/mozilla-b2g/gaia/commit/b6e702681a3b7d440d55e1decffd9672f7561e04

Comment 24

[Robert Chira [:RobertC]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/22733

Unxfailed test_contact_prompt on v2.0

Comment 25

[Viorela Ioia [:viorela]]

Merged on v2.0: https://github.com/mozilla-b2g/gaia/commit/9f94a78eef3a9305140c550c983871a46b0692e7