1024940 - [Settings] Permissions that are explicit for privileged or web apps are not shown on Settings -> Apps permissions

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Antonio Manuel Amaya Calvo (:amac)]

+++ This bug was initially created as a clone of Bug #1024513 +++

STR:

1. Generate and flash a engineering build
2. Go to Settings -> App permissions.
3. Tap on the "UI tests - Privileged App"

EXPECTED

The app detail page should show (and allow modifying) the following permissions:
* Geolocation
* audio-capture
* video-capture
* contacts
* device-storage

ACTUAL

The app detail page only shows the geolocation permission.

CAUSE:

The list of permissions for each app is filled at:

https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/js/panels/app_permissions_detail/app_permissions_detail.js#L75

explicitCertifiedPermissions is filled at:

https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/js/panels/app_permissions_list/app_permissions_list.js#L173

And the manifestURL for the settings app (which is certified) is passed at that point. And so only permissions that are explicit for certified apps are shown (which matches the var name, but it's an incorrect behavior).

Comment 1

[Antonio Manuel Amaya Calvo (:amac)]

Requesting block on this. If this isn't fixed, the users won't be able to change the explicit permissions they give to apps once they're saved.

Comment 2

[Jason Smith [:jsmith]]

Adding QA Wanted to check 1.4.

Comment 3

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Issue DOES NOT occur in latest 1.4 Flame build.  App has permissions for many categories instead of just Geolocation.

Environmental Variables:
Device: Flame 1.4
Build ID: 20140610034016
Gaia: c39db439202b29897bee9896bc789e6782809f3a
Gecko: edd648be2b07
Version: 30.0 (1.4)
Firmware Version: v10G-2

UI tests - Privileged App is not avialable on the Flame 121-2 base.


Variables for other builds:

Issue DOES occur on 2.1 Flame.  App permissions only has Geolocation.

Environmental Variables:
Device: Flame 2.1 - Master
BuildID: 20140612172427
Gaia: 90777363ed0a4e6d32612074a12fb2c73c353a25
Gecko: adcf3f05f813
Version: 33.0a1 (2.1 - Master) 
Firmware Version: v121-2

Issue DOES occur on 2.1 Buri. App permissions only has Geolocation.

Environmental Variables:
Device: Buri 2.1 - Master
BuildID: 20140612173627
Gaia: 5b4b4fc17a8e4a513a977f7062ea3e65d26ce268
Gecko: 48eee276b1ee
Version: 33.0a1 (2.1 - Master) 
Firmware Version: v1.2device.cfg

Issue DOES occur on 2.1 Open C. App permissions only has Geolocation.

Environmental Variables:
Device: Open_C 2.1 - Master
BuildID: 20140612172427
Gaia: 90777363ed0a4e6d32612074a12fb2c73c353a25
Gecko: adcf3f05f813
Version: 33.0a1 (2.1 - Master) 
Firmware Version: P821A10V1.0.0B06_LOG_DL

Issue DOES occur on 2.0 Open C.App permissions only has Geolocation.

Device: Open_C 2.0
BuildID: 20140613082917
Gaia: 5b1fdc6000d35962769e789b924b24e166a27759
Gecko: 8415553664fd
Version: 32.0a2 (2.0) 
Firmware Version: P821A10V1.0.0B06_LOG_DL

Issue DOES occur on 2.0 Buri. App permissions only has Geolocation.

Environmental Variables:
Device: Buri 2.0
BuildID: 20140613123412
Gaia: 5b1fdc6000d35962769e789b924b24e166a27759
Gecko: e161f3e3b332
Version: 32.0a2 (2.0) 
Firmware Version: v1.2device.cfg

Comment 4

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

B2g-inbound Regression Window

Last working 
Environmental Variables:
Device: Flame
BuildID: 20140427173001
Gaia: f50d8a3504e0a57d371457c50a6ced333e20724d
Gecko: 6c03acf73b19
Version: 31.0a1

First Broken 
Environmental Variables:
Device: Flame
BuildID: 20140427203001
Gaia: cadddcac2b8ce162a5e27e6dc105557b00a94478
Gecko: f3d4579157e9
Version: 31.0a1

Last working gaia / First broken gecko - Issue does NOT occur
Gaia: f50d8a3504e0a57d371457c50a6ced333e20724d
Gecko: f3d4579157e9

First broken gaia / Last working gecko - Issue DOES occur 
Gaia: cadddcac2b8ce162a5e27e6dc105557b00a94478
Gecko: 6c03acf73b19

Gaia Pushlog:  https://github.com/mozilla-b2g/gaia/compare/f50d8a3504e0a57d371457c50a6ced333e20724d...cadddcac2b8ce162a5e27e6dc105557b00a94478

Comment 5

[Jason Smith [:jsmith]]

Broken by bug 973454

George - Can you take a look?

Comment 6

[bhavana bajaj [:bajaj]]

I would prefer we back 973454 if that lower risk to avoid this regression.

IS 1024513 also a fallout from bug 973454 ?

Comment 7

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to master

Hi Arthur,
could you help me to check this fix?
I should scan planPermissions and composedPermissions again for each app.

Comment 8

[Tim Guan-tin Chien [:timdream] (please needinfo)]

George, what's the risk if we backout bug 973454 in 2.0 ONLY and this bug off 2.0+ list (and other possible regressions?)

Can be backout that cleanly from 2.0 at this stage?

Comment 9

[Arthur Chen [:arthurcc][inactive after 6/30]]

The patch for bug 973454 could be backed out cleanly, but I would prefer to keep the patch for bug 973454 in v2.0 with this bug fixed.

Comment 10

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to Arthur Chen [:arthurcc] from comment #9)
> The patch for bug 973454 could be backed out cleanly, but I would prefer to
> keep the patch for bug 973454 in v2.0 with this bug fixed.

OK.

Comment 11

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8441803 [details] [review]
PR to master

Looks good to me, thank you!

Comment 12

[(Inactive after June) George Duan [:gduan] [:喬智]]

Thanks!

tbpl passed
https://tbpl.mozilla.org/?tree=Gaia-Try&rev=e183a7977e0dfbbd48524e6c02065321bc53edbc

merge to master
https://github.com/mozilla-b2g/gaia/commit/140637c94152b1da9bc6f1b51df15b1d2e90c6fe

Comment 13

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/90123cc059fc78c5c81ef04d629d87be0bdcd8e5