1146482 - (MediaMonitor) Remove the MediaDecoder monitor

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Bobby Holley (:bholley)]

In my overhaul of the media threading model, the end goal is a world where we have clear rules for which threads own which state. In this world, we won't have a need for the monolithic decoder monitor, so removing it is a good indication that we're finally on solid footing.

We're a ways away from being able to do this, but I want to get a bug on file so that I can start racking up dependencies.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

All dependents are resolved.

Comment 2

[Jean-Yves Avenard [:jya]]

yeah !

let's drink to that !

Comment 3

[Bobby Holley (:bholley)]

It looks like MediaDecoder::mReentrantMonitor is still there (but unused). Can we Resolve this bug by removing it? :-)

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Oops! I will do it now. Thanks for the reminding.

Comment 5

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1146482 - remove MediaDecoder::mReentrantMonitor which is not used anymore. r=jya.

Bug 1146482 - remove MediaDecoder::mReentrantMonitor which is not used anymore. r=jya.

Comment 6

[Jean-Yves Avenard [:jya]]

Comment on attachment 8670672 [details]
MozReview Request: Bug 1146482 - remove MediaDecoder::mReentrantMonitor which is not used anymore. r=jya.

https://reviewboard.mozilla.org/r/21427/#review19311

Comment 7

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cd59b5c9d812

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/cd59b5c9d812

Comment 10

[Bobby Holley (:bholley)]

You are so awesome JW - Thanks ten thousand times for carrying this to the finish line!

Comment 11

[JW Wang [:jwwang] [:jw_wang]]

Thanks Bobby. You've done most of the works and invent useful async tools (promise, mirroring) that help a lot on the way. Thanks.