1209864 - Remove usage of decoder monitor from MediaOmxCommonDecoder

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[JW Wang [:jwwang] [:jw_wang]]

https://hg.mozilla.org/mozilla-central/file/acdb22976ff8/dom/media/omx/MediaOmxCommonDecoder.cpp#l49

This must be done before bug 1208934 because CheckDecoderCanOffloadAudio() is called from multiple threads. We will make all methods of MediaOmxCommonDecoder run on the main thread in this bug.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

CheckDecoderCanOffloadAudio() is introduced in bug 1053186. Make sure not to cause regression when fixing this bug.

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ceb60c399f0f

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1209864. Part 1 - make all methods run on the main thread and remove usage of the decoder monitor.

Bug 1209864. Part 1 - make all methods run on the main thread and remove usage of the decoder monitor.

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1209864. Part 2 - remove unused code. r=sotaro.

Bug 1209864. Part 2 - remove unused code.

Comment 5

[JW Wang [:jwwang] [:jw_wang]]

It looks like roc is on PTO.

Comment 6

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8668226 [details]
MozReview Request: Bug 1209864. Part 1 - make all methods run on the main thread and remove usage of the decoder monitor.

Bug 1209864. Part 1 - make all methods run on the main thread and remove usage of the decoder monitor.

Comment 7

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8668227 [details]
MozReview Request: Bug 1209864. Part 2 - remove unused code. r=sotaro.

Bug 1209864. Part 2 - remove unused code.

Comment 8

[Sotaro Ikeda [:sotaro]]

Comment on attachment 8668226 [details]
MozReview Request: Bug 1209864. Part 1 - make all methods run on the main thread and remove usage of the decoder monitor.

https://reviewboard.mozilla.org/r/20905/#review19041

Comment 9

[Sotaro Ikeda [:sotaro]]

Comment on attachment 8668227 [details]
MozReview Request: Bug 1209864. Part 2 - remove unused code. r=sotaro.

https://reviewboard.mozilla.org/r/20907/#review19039

Comment 10

[Sotaro Ikeda [:sotaro]]

Comment on attachment 8668226 [details]
MozReview Request: Bug 1209864. Part 1 - make all methods run on the main thread and remove usage of the decoder monitor.

https://reviewboard.mozilla.org/r/20905/#review19055

::: dom/media/omx/MediaOmxCommonDecoder.cpp:91
(Diff revision 1)
> +    GetStateMachine()->DispatchAudioOffloading(false);

It might be better to add a comment why the call is necessary. Because MDSM's default value is false.

::: dom/media/omx/MediaOmxCommonDecoder.cpp:102
(Diff revision 1)
> +    GetStateMachine()->DispatchAudioOffloading(false);

Same as above.

Comment 11

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8668226 [details]
MozReview Request: Bug 1209864. Part 1 - make all methods run on the main thread and remove usage of the decoder monitor.

Bug 1209864. Part 1 - make all methods run on the main thread and remove usage of the decoder monitor.

Comment 12

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8668227 [details]
MozReview Request: Bug 1209864. Part 2 - remove unused code. r=sotaro.

Bug 1209864. Part 2 - remove unused code. r=sotaro.

Comment 13

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8668226 [details]
MozReview Request: Bug 1209864. Part 1 - make all methods run on the main thread and remove usage of the decoder monitor.

https://reviewboard.mozilla.org/r/20905/#review19077

Comment 14

[JW Wang [:jwwang] [:jw_wang]]

Thanks for the review!

Comment 15

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8bbb629f0d54
https://hg.mozilla.org/integration/mozilla-inbound/rev/1be141d7888c

Comment 16

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8bbb629f0d54
https://hg.mozilla.org/mozilla-central/rev/1be141d7888c