1194080 - Implement MP3TrackDemuxer::GetBuffered

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P2)

Description

[Jean-Yves Avenard [:jya]]

The code indicates that this is dependent on bug 1169485 to be done.

But GetBuffered() is required even without MSE.

It must be implemented if we are to enable the MP3Demuxer

Comment 2

[Jean-Yves Avenard [:jya]]

Attachment: [mp3] Implement MP3TrackDemuxer::GetBuffered().

This is done by roughly estimated the duration of the MediaResource buffered range from the average bitrate.

Comment 3

[Eugen Sawin [:esawin]]

Comment on attachment 8668380 [details] [diff] [review]
[mp3] Implement MP3TrackDemuxer::GetBuffered().

Review of attachment 8668380 [details] [diff] [review]:
-----------------------------------------------------------------

This depends on stable/consistent values returned by MediaResource::GetLength, but so does a lot of other code.
LGTM.

::: dom/media/MP3Demuxer.h
@@ +27,5 @@
>    void NotifyDataArrived(uint32_t aLength, int64_t aOffset) override;
>    void NotifyDataRemoved() override;
> +  // Do not shift the calculated buffered range by the start time of the first
> +  // decoded frame. The mac MP3 decoder will buffer some samples and the first
> +  // frame returned has typically a start time that is non-zero ; causing our

Redundant space before ;.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4e3ec1168d62

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4e3ec1168d62