1209410 - Use MP3Demuxer/MediaFormatReader by default when available

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Jean-Yves Avenard [:jya]]

The current code makes assumption based on pref and some static rules.

As we are removing the legacy MP3 readers and instead use the new MP3Demuxer ; we need to test if a MP3 decoder is available on the current PlatformDecoderModule instance.

Comment 1

[Jean-Yves Avenard [:jya]]

changing title, fairly certain there's already a bug opened for it, but can't find it

Comment 2

[Jean-Yves Avenard [:jya]]

Attachment: [mp3] P1. Use new MP3Demuxer when possible.

Comment 3

[Jean-Yves Avenard [:jya]]

Attachment: [webm] Never use gstreamer to decode webm.

Comment 4

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1209388: [mp3] Remove AppleMP3Reader.

Following bug 1209410, it was no longer used.

Comment 5

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8667147 [details] [diff] [review]
[mp3] P1. Use new MP3Demuxer when possible.

Review of attachment 8667147 [details] [diff] [review]:
-----------------------------------------------------------------

We will need to be on the lookout for regressions from this.

Comment 6

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1209388: [mp3] Remove AppleMP3Reader.

Following bug 1209410, it was no longer used.

Comment 7

[Jean-Yves Avenard [:jya]]

Comment on attachment 8667723 [details] [diff] [review]
Bug 1209388: [mp3] Remove AppleMP3Reader.

wrong bug #

Comment 8

[Jean-Yves Avenard [:jya]]

Actually, this cause failure on try as the MP3Demuxer always returns an empty buffered range.

Mark dependency on bug 1194080

Comment 9

[Jean-Yves Avenard [:jya]]

Attachment: [mp3] P3. Implement canPlayType for new MP3Decoder.

I plan to rewrite everything in bug 1210667, but in the mean time, this will do.

Comment 10

[Jean-Yves Avenard [:jya]]

Attachment: [mp3] P4. Change duration of mp3 files used by mochitests.

The owl.mp3 file and derivative is made of 128 0.026122s long samples , which gives us an actual duration of 3.343616s. However, when decoding those files, the first two samples are dropped by the CoreAudio and WMF decoder giving us an actual play time of 3.29s.
We have no way to determine the exact duration at the demuxing stage. External readers such as DirectShow or GStreamer would only report the decoded frames time, while the MediaFormatReader report the demuxed time.

There is no right answer here. So setting a duration that will allow all readers to pass the tests.

I may have to adjust the duration slightly for Windows XP.

Comment 11

[Jean-Yves Avenard [:jya]]

Comment on attachment 8667153 [details] [diff] [review]
Bug 1209388: [mp3] Remove AppleMP3Reader.

moved to bug 1209388

Comment 12

[Jean-Yves Avenard [:jya]]

I think we should finally be good to go:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a71c72405635

Comment 13

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/33d14f3ca37f
https://hg.mozilla.org/integration/mozilla-inbound/rev/2aaa7507799b
https://hg.mozilla.org/integration/mozilla-inbound/rev/1c5bdbce9ea1
https://hg.mozilla.org/integration/mozilla-inbound/rev/a61e8244ad6b

Comment 14

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/33d14f3ca37f
https://hg.mozilla.org/mozilla-central/rev/2aaa7507799b
https://hg.mozilla.org/mozilla-central/rev/1c5bdbce9ea1
https://hg.mozilla.org/mozilla-central/rev/a61e8244ad6b