1543027 - Snapping Picture-In-Picture videos to the left/right/top with the mouse displays thick white bars on the video's sides

Status: VERIFIED FIXED

(Toolkit :: Video/Audio Controls, defect, P2)

Description

[Itiel]

Attachment: Snapping to the right

STR:

1. Use Windows
2. Open any video in Picture-In-Picture mode
3. Press Win key+left/right/up arrow keys

AR:
a. Snapping the video to the top once adds 2 big white bars to the video (one above the video and another on its bottom) covering half of the screen
b. Snapping the video to the right/left adds 2 white bars to the video (one on its right and another on its left). Also the video gets ~2x bigger
c. Snapping the video to the top twice makes the video look the same as in #b, but on the upper part of the screen
d. Snapping the video to the top thrice makes it go fullscreen, and adds a white bar to the video's bottom part

ER:
No white bars, and potentially no 2x bigger videos (?)

Comment 1

[Itiel]

Attachment: Snapping to the top once

Comment 2

[Itiel]

Attachment: Snapping to the top thrice

Comment 3

[Itiel]

You'll need to open the third attachment here in a new tab to see the white bar at the bottom.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

It seems we can disable Windows Aero snap for the PiP windows when it's of type "dialog".

Patch coming up.

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1543027 - Make Picture-in-Picture player window a dialog window type. r?JSON_Voorhees

This also seems to make the player window buttons work more reliably with touchscreens.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/969b3828a301
Make Picture-in-Picture player window a dialog window type. r=JSON_voorhees

Comment 8

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/969b3828a301

Comment 9

[Itiel]

I'm on the latest Nightly and this doesn't seem to be fixed, but bug 1543031 and bug 1536011 are fixed here, so this patch should be included in my Nightly.. I'm on Windows 10.
mconley, what info do you need to debug this?

Comment 10

[Timea Cernea [:tbabos][inactive]]

Can confirm what Itiel said, this is still reproducible on latest Nightly 71.0a1 (2019-09-16) (64-bit).
Mike, should we re-open this one or submit a new bug?

Comment 11

[Timea Cernea [:tbabos][inactive]]

Attachment: LatestNightly

Comment 12

[Mike Conley (:mconley) (:⚙️)]

Gah, when I was testing this, I was snapping with the mouse and not the keyboard. :(

Yes, I'll get a new bug on file.

Comment 13

[Cristian Fogel [:cfogel]]

Confirmed issue with 68.0a1 (2019-04-09).
Verified fix with 71.0b5.