Closed Bug 1820805 Opened 2 years ago Closed 2 years ago

Store source object instead of only sourceId in tabs reducers

Categories

(DevTools :: Debugger, task)

task

Tracking

(firefox113 fixed)

RESOLVED FIXED
113 Branch
Tracking Status
firefox113 --- fixed

People

(Reporter: ochameau, Assigned: ochameau)

References

Details

Attachments

(1 file, 1 obsolete file)

Alongside bug 1818496, this will allow to remove the last dependency on sources reducers internal map of all the sources.
This will also allow to drop all lookup where we retrieve the source object for the given tab's sourceId.

Blocks: 1820806

As these objects are immutable, we can store them in tabs reducer instead
of doing many lookup based on the IDs.

This should ultimately help make the sources Map become mutable.

Assignee: nobody → poirot.alex
Status: NEW → ASSIGNED

As these objects are immutable, we can store them in tabs reducer instead
of doing many lookup based on the IDs.

This should ultimately help make the sources Map become mutable.

Attachment #9323445 - Attachment is obsolete: true
Pushed by apoirot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/02d6691267ac [devtools] Store source and source actor objects in tab objects. r=devtools-reviewers,bomsy
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 113 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: