1820806 - Make the map of all sources mutable

Status: RESOLVED FIXED

(DevTools :: Debugger, task)

Description

[Alexandre Poirot [:ochameau]]

Thanks to bug 1818496 and bug 1820805 we should be able to make the Map of all sources become mutable and avoid having to clone it on each new/removed source!

Comment 1

[Alexandre Poirot [:ochameau]]

Surprisingly, DAMP doesn't report much improvements:
https://treeherder.mozilla.org/perfherder/comparesubtest?originalProject=try&newProject=try&newRevision=ebd889ff5451d6279746e5b38bb4869d3736c331&originalSignature=4081483&newSignature=4081483&framework=12&application=&originalRevision=186a501af7d55ef9604ec7844cce7ced213d36ab&page=1&showOnlyConfident=1
Only some in project search.

We probably miss some test adding sources on an already large dataset.

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1820806 - [devtools] Stop exporting the sources Map.

Comment 3

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1820806 - [devtools] Stop cloning the Map of all the sources.

Now that this Map is only used internaly to sources reducer and selectors
and that we never return its raw reference, we can make it mutable.

Comment 4

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1820806 - [devtools] Stop exporting the sources Map.

Comment 5

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1820806 - [devtools] Stop cloning the Map of all the sources.

Now that this Map is only used internaly to sources reducer and selectors
and that we never return its raw reference, we can make it mutable.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3f5a54e57c88
[devtools] Stop exporting the sources Map. r=devtools-reviewers,bomsy
https://hg.mozilla.org/integration/autoland/rev/a9a5907dc0a3
[devtools] Stop cloning the Map of all the sources. r=devtools-reviewers,bomsy

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/3f5a54e57c88
https://hg.mozilla.org/mozilla-central/rev/a9a5907dc0a3

Comment 8

[Nicolas Chevobbe [:nchevobbe]]

== Change summary for alert #37708 (as of Sun, 19 Mar 2023 02:19:34 GMT) ==

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
48%	reload-debugger:parent-process objects-with-no-stacks	linux1804-64-tsan-qr		565.67 -> 294.33
13%	damp custom.jsdebugger.stepOver.DAMP	windows10-64-shippable-qr	e10s fission stylo webrender-sw	435.48 -> 379.01
13%	damp custom.jsdebugger.project-search.DAMP	windows10-64-shippable-qr	e10s fission stylo webrender-sw	1,904.20 -> 1,665.54
12%	damp custom.jsdebugger.project-search.DAMP	windows10-64-shippable-qr	e10s fission stylo webrender	1,949.32 -> 1,705.96
11%	damp custom.jsdebugger.stepOver.DAMP	windows10-64-shippable-qr	e10s fission stylo webrender	437.05 -> 387.01
...	...	...	...	...
2%	damp browser-toolbox.debugger-ready.DAMP	windows10-64-shippable-qr	e10s fission stylo webrender-sw	1,077.45 -> 1,054.94

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=37708